test: reserve sample deterministic test + benchmarks#5374
Merged
Conversation
acud
force-pushed
the
add-sample-test-norandom
branch
from
7e8d8b3 to
15cb058
Compare
acud
force-pushed
the
add-sample-test-norandom
branch
from
15cb058 to
058395c
Compare
acud
changed the title
acud
changed the title
acud
changed the title
acud
force-pushed
the
add-sample-test-norandom
branch
from
99680d0 to
4ad31d6
Compare
akrem-chabchoub
approved these changes
Feb 24, 2026
| } | ||
| } | ||
|
|
||
| // Benchmark results: |
Contributor
There was a problem hiding this comment.
Why it is intentional to keep benchmark results here ?
Contributor
Author
There was a problem hiding this comment.
so that when we improve on them later on, that there's a baseline to compare it against
| } | ||
|
|
||
| func TestDecryptRef_Publisher(t *testing.T) { | ||
| t.Parallel() |
Contributor
There was a problem hiding this comment.
This is for flaky test ? or something else ?
martinconic
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a non-random test to the reserve sample and some benchmarks as a baseline.
Needed for verifying that ReserveSample reaches the same result deterministically (and covers an e2e over all the hashing operations involved).
Benchmarks are needed for ReserveSample optimization.